Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4319] Make title of document configurable in StUF-ZDS #4906

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 12, 2024

Closes #4319

Changes

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (c07912d) to head (f12f23c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4906   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         758      758           
  Lines       25798    25798           
  Branches     3390     3390           
=======================================
  Hits        24919    24919           
  Misses        613      613           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as draft December 12, 2024 09:33
@vaszig vaszig marked this pull request as ready for review December 13, 2024 12:30
@vaszig vaszig force-pushed the task/4319-define-filename-in-stufzds-and-zgw branch from 88f5090 to f12f23c Compare December 16, 2024 15:37
@sergei-maertens sergei-maertens merged commit 9be9f8c into master Dec 16, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the task/4319-define-filename-in-stufzds-and-zgw branch December 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als zaak-behandelaar wil ik dat documenten een meer sprekende titel krijgen
2 participants